gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1738784556
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datablock/DataBlockTest.java:
##########
@@ -83,11 +83,19 @@ public void testAllDataTypes(int nullPercentile)
for (int colId = 0; colId < dataSchema.getColumnNames().length; colId++) {
ColumnDataType columnDataType = dataSchema.getColumnDataType(colId);
for (int rowId = 0; rowId < TEST_ROW_COUNT; rowId++) {
- Object rowVal = DataBlockTestUtils.getElement(rowBlock, rowId, colId,
columnDataType);
- Object colVal = DataBlockTestUtils.getElement(columnarBlock, rowId,
colId, columnDataType);
- Assert.assertEquals(rowVal, colVal,
- "Error comparing Row/Column Block at (" + rowId + "," + colId +
")" + " of Type: " + columnDataType
- + "! rowValue: [" + rowVal + "], columnarValue: [" + colVal +
"]");
+ try {
+ Object rowVal = DataBlockTestUtils.getElement(rowBlock, rowId,
colId, columnDataType);
+ Object colVal = DataBlockTestUtils.getElement(columnarBlock, rowId,
colId, columnDataType);
+ Assert.assertEquals(rowVal, colVal,
+ "Error comparing Row/Column Block at (" + rowId + "," + colId +
")" + " of Type: " + columnDataType
+ + "! rowValue: [" + rowVal + "], columnarValue: [" + colVal
+ "]");
+ } catch (AssertionError e) {
+ throw new AssertionError(
+ "Error comparing Row/Column Block at (" + rowId + "," + colId +
") of Type: " + columnDataType + "!", e);
Review Comment:
TBH I don't remember. Probably to catch errors produced by assertions in
DataBlockTestUtils.getElement. I can change the code to make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
