yashmayya commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1740701763
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java:
##########
@@ -104,4 +113,39 @@ public static Type fromOrdinal(int ordinal) {
}
}
}
+
+ /**
+ * Returns the dictionary for the given column.
+ *
+ * This is a break in the interface abstraction that assumes all
implementations will use a dictionary only for
+ * string columns. This may change in the future.
+ */
+ @Nullable
+ String[] getStringDictionary();
+
+ /**
+ * The actual content is different depending on whether this is a row-based
or columnar data block.
+ *
+ * This is an abstraction leak that assumes all implementations derive from
{@link BaseDataBlock}.
Review Comment:
Thanks, that was a useful history lesson 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
