gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1734717024
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java:
##########
@@ -104,4 +117,44 @@ public static Type fromOrdinal(int ordinal) {
}
}
}
+
+ /**
+ * A raw representation of the block.
+ * <p>
+ * Do not confuse this with the serialized form of the block. This is a
representation of the block in memory and
+ * it is completely dependent on the current Pinot version. That means that
this representation can change between
+ * Pinot versions.
+ * <p>
+ * The {@link DataBlockSerde} is responsible for serializing and
deserializing this raw representation into a binary
+ * format that is compatible with the other Pinot versions.
+ */
+ interface Raw {
Review Comment:
I don't like that solution, but given both of you seem to prefer that, I've
changed the implementation to remove Raw and instead move these methods into
DataBlock. Initially I've tried to move them in BaseDataBlock, but it would
require to change a lot of code or create unsafe casts for no actual benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
