satishd commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1517531643
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -572,7 +573,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// Decode message
StreamDataDecoderResult decodedRow =
_streamDataDecoder.decode(messagesAndOffsets.getStreamMessage(index));
msgMetadata = messagesAndOffsets.getStreamMessage(index).getMetadata();
- StreamPartitionMsgOffset messageOffset =
messagesAndOffsets.getNextStreamPartitionMsgOffsetAtIndex(index);
+ int messageOffset = messagesAndOffsets.getMessageOffsetAtIndex(index);
Review Comment:
[MessageBatch](https://github.com/apache/pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java#L73)'s
`getMessageOffsetAtIndex(index)` javadoc says it gives the offset of the
message at the given index. But the respective Kafka implementation does not
seem to return that. What does that method really mean and what is it used for?
We need Kafka message's record offset here. So, we need a similar
implementation like `getNextStreamPartitionMsgOffsetAtIndex()` to get it from
the metadata properties and get the message record's offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
