tibrewalpratik17 commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1348874021
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -157,6 +161,58 @@ default boolean isSampledRequest() {
void setReduceTimeMillis(long reduceTimeMillis);
+ long getNumConsumingSegmentsQueried();
+
+ void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried);
+
+ long getNumConsumingSegmentsProcessed();
+
+ void setNumConsumingSegmentsProcessed(long numConsumingSegmentsProcessed);
+
+ long getNumConsumingSegmentsMatched();
+
+ void setNumConsumingSegmentsMatched(long numConsumingSegmentsMatched);
+
+ long getMinConsumingFreshnessTimeMs();
+
+ void setMinConsumingFreshnessTimeMs(long minConsumingFreshnessTimeMs);
+
+ long getNumSegmentsPrunedByBroker();
+
+ void setNumSegmentsPrunedByBroker(long numSegmentsPrunedByBroker);
+
+ long getNumSegmentsPrunedByServer();
+
+ void setNumSegmentsPrunedByServer(long numSegmentsPrunedByServer);
+
+ long getNumSegmentsPrunedInvalid();
+
+ void setNumSegmentsPrunedInvalid(long numSegmentsPrunedInvalid);
+
+ long getNumSegmentsPrunedByLimit();
+
+ void setNumSegmentsPrunedByLimit(long numSegmentsPrunedByLimit);
+
+ long getNumSegmentsPrunedByValue();
+
+ void setNumSegmentsPrunedByValue(long numSegmentsPrunedByValue);
+
+ long getExplainPlanNumEmptyFilterSegments();
+
+ void setExplainPlanNumEmptyFilterSegments(long
explainPlanNumEmptyFilterSegments);
+
+ long getExplainPlanNumMatchAllFilterSegments();
+
+ void setExplainPlanNumMatchAllFilterSegments(long
explainPlanNumMatchAllFilterSegments);
+
+ Map<String, String> getTraceInfo();
+
+ void setTraceInfo(Map<String, String> traceInfo);
Review Comment:
Yes but we would still want to keep the trace-info in the event so that we
can persist it in Kafka / Hive and refer it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
