siddharthteotia commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1345337649
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -63,6 +67,19 @@ public class DefaultRequestContext implements RequestScope {
private FanoutType _fanoutType;
private int _numUnavailableSegments;
+ private long _numConsumingSegmentsQueried;
Review Comment:
Not directly related to this PR -- I don't think we track
RequestCompilationTime in BrokerResponse or RequestContext statistics. It is
emitted as a metric from the code.
But I guess we should. Within LinkedIn we have always had requests that can
take tens to hundreds of ms to compile a query. Will become more relevant in
the context of multi stage engine imo.
Need not necessarily do as part of this PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
