tibrewalpratik17 commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1346452689


##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -63,6 +67,19 @@ public class DefaultRequestContext implements RequestScope {
 
   private FanoutType _fanoutType;
   private int _numUnavailableSegments;
+  private long _numConsumingSegmentsQueried;

Review Comment:
   Yes the plan is to add more metrics as need be. Thanks for bring this up - 
`RequestCompilationTime`. I am planning to add `stageStats` as well for 
multistage queries but that needs some discussion. Will take adding 
`RequestCompilationTime` in a follow-up PR. This PR tries to get alignment 
between brokerResponse and RequestContext class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to