walterddr commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1348824037
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -91,7 +95,7 @@ default boolean isSampledRequest() {
String getQuery();
- String getTableName();
+ List<String> getTableNames();
Review Comment:
should keep getTableName and add a getTableNames
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -157,6 +161,58 @@ default boolean isSampledRequest() {
void setReduceTimeMillis(long reduceTimeMillis);
+ long getNumConsumingSegmentsQueried();
+
+ void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried);
+
+ long getNumConsumingSegmentsProcessed();
+
+ void setNumConsumingSegmentsProcessed(long numConsumingSegmentsProcessed);
+
+ long getNumConsumingSegmentsMatched();
+
+ void setNumConsumingSegmentsMatched(long numConsumingSegmentsMatched);
+
+ long getMinConsumingFreshnessTimeMs();
+
+ void setMinConsumingFreshnessTimeMs(long minConsumingFreshnessTimeMs);
+
+ long getNumSegmentsPrunedByBroker();
+
+ void setNumSegmentsPrunedByBroker(long numSegmentsPrunedByBroker);
+
+ long getNumSegmentsPrunedByServer();
+
+ void setNumSegmentsPrunedByServer(long numSegmentsPrunedByServer);
+
+ long getNumSegmentsPrunedInvalid();
+
+ void setNumSegmentsPrunedInvalid(long numSegmentsPrunedInvalid);
+
+ long getNumSegmentsPrunedByLimit();
+
+ void setNumSegmentsPrunedByLimit(long numSegmentsPrunedByLimit);
+
+ long getNumSegmentsPrunedByValue();
+
+ void setNumSegmentsPrunedByValue(long numSegmentsPrunedByValue);
+
+ long getExplainPlanNumEmptyFilterSegments();
+
+ void setExplainPlanNumEmptyFilterSegments(long
explainPlanNumEmptyFilterSegments);
+
+ long getExplainPlanNumMatchAllFilterSegments();
+
+ void setExplainPlanNumMatchAllFilterSegments(long
explainPlanNumMatchAllFilterSegments);
+
+ Map<String, String> getTraceInfo();
+
+ void setTraceInfo(Map<String, String> traceInfo);
Review Comment:
i am not sure default creating these for tracing is a good idea. normally we
dont enable tracing for production use case, so for those that were manually
enabled, those must've been monitored and thus renders it less useful to keep
the event listener (e.g. there's a human tracking it already)
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -63,7 +67,7 @@ default boolean isSampledRequest() {
void setQuery(String pql);
- void setTableName(String tableName);
+ void setTableNames(List<String> tableNames);
Review Comment:
should not change the function signature in this API directly IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
