siddharthteotia commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1345317108
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -402,6 +419,136 @@ public void setReduceTimeMillis(long reduceTimeMillis) {
_reduceTimeMillis = reduceTimeMillis;
}
+ @Override
+ public long getNumConsumingSegmentsQueried() {
+ return _numConsumingSegmentsQueried;
+ }
+
+ @Override
+ public void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried)
{
Review Comment:
(nit) I think we can use int instead of long here. May not really matter in
the grand scheme of things but off late we have seen a lot of heap usage
improvement opportunities from production heap dumps. So just something to
consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
