snleee commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1253930435
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegments(
}
}
+ @DELETE
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/segments/{tableName}/select")
Review Comment:
@wirybeaver
We can change the convention to be:
`Delete all segments -> delete all segments that satisfies the filter`.
`startTime, endTime, excludeReplacedSegments`. Please take a look at
`/segments/{tableName}`. It already has those filters for fetching segments.
We can keep the backward compatibility by picking all segments if no filter
is provided. How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
