snleee commented on code in PR #10758: URL: https://github.com/apache/pinot/pull/10758#discussion_r1262799680
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ########## @@ -884,6 +865,52 @@ public SuccessResponse deleteSegments( } } + @DELETE + @Consumes(MediaType.APPLICATION_JSON) + @Produces(MediaType.APPLICATION_JSON) + @Path("/segments/{tableName}/select") Review Comment: I see. You need the protection. In that case, I'm good with keeping the separate API. It would be nice to have if 'DELETE /segments' also gets extra filter just to have the feature parity with `GET /segments`. Anyway, this can be addressed as part of the separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org