snleee commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1261943671
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegments(
}
}
+ @DELETE
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/segments/{tableName}/select")
Review Comment:
@wirybeaver sorry for the late response on this.
The current behavior for `DELETE /segments/{tableName}` API is already to
delete all segments in the table.
Adding filter (start, end) means that we will delete the segments matching
the filter. I think that we are keeping the backward compatibility and not
breaking any existing behavior?
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
