[GitHub] [pinot] jtao15 commented on a diff in pull request #10758: Add a new controller endpoint for segment deletion with a time window

[via GitHub]

jtao15 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228816672


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,47 @@ public SuccessResponse deleteSegments(
     }
   }
 
+  @DELETE
+  @Consumes(MediaType.APPLICATION_JSON)
+  @Produces(MediaType.APPLICATION_JSON)
+  @Path("/segments/{tableName}/select")

Review Comment:
   Can you please elaborate on why a new api is needed instead of adding more 
parameters for the existing segment deletion api?



##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1130,4 +1152,38 @@ private SuccessResponse 
updateZKTimeIntervalInternal(String tableNameWithType) {
       }
       return new SuccessResponse("Successfully updated time interval zk 
metadata for table: " + tableNameWithType);
   }
+
+  public List<Pair<TableType, List<String>>> selectSegments(
+      String tableName,

Review Comment:
   (nit) we usually don't list parameters on separate lines?



##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1130,4 +1152,38 @@ private SuccessResponse 
updateZKTimeIntervalInternal(String tableNameWithType) {
       }
       return new SuccessResponse("Successfully updated time interval zk 
metadata for table: " + tableNameWithType);
   }
+
+  public List<Pair<TableType, List<String>>> selectSegments(

Review Comment:
   Possible to refactor `getSelectedSegments()` with the same util function as 
well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org