tibrewalpratik17 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228721254
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentRestletResourceTest.java:
##########
@@ -165,6 +165,30 @@ public void testSegmentCrcApi()
checkCrcRequest(rawTableName, segmentMetadataTable, 9);
}
+ @Test
+ public void testDeleteSegmentsWithTimeWindow()
Review Comment:
This test does not cover for a particular window but dropping all segments
right? Should we rename it accordingly or enhance the test?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1130,4 +1152,38 @@ private SuccessResponse
updateZKTimeIntervalInternal(String tableNameWithType) {
}
return new SuccessResponse("Successfully updated time interval zk
metadata for table: " + tableNameWithType);
}
+
+ public List<Pair<TableType, List<String>>> selectSegments(
Review Comment:
Are we planning to add UTs for this method? If not, can we make this private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
