wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228752953
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentRestletResourceTest.java:
##########
@@ -165,6 +165,30 @@ public void testSegmentCrcApi()
checkCrcRequest(rawTableName, segmentMetadataTable, 9);
}
+ @Test
+ public void testDeleteSegmentsWithTimeWindow()
Review Comment:
The endpoint is different with the one that drop all segments.
ControllerTest.sendDeleteRequest(urlBuilder.forSegmentDeleteAPI(rawTableName))
will return /segments/<table>/select. The normal endpoint to drop all segments
is /segments/<table>
The reason why I don't specify the time range is because mockSegmentMetadata
hard code the time range to 1L-10L. If the time window option is not claimed,
the start and end will be filled with default value [0, +inf].
I can specify time range [0, Long.MAX_VALUE].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
