swaminathanmanish commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1136382305
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##########
@@ -112,14 +112,14 @@ public static String
constructPropertyStorePathForInstancePartitions(String inst
return StringUtil.join("/", PROPERTYSTORE_INSTANCE_PARTITIONS_PREFIX,
instancePartitionsName);
}
- public static String constructPropertyStorePathForControllerJob() {
Review Comment:
@saurabhd336 and I chatted about this and included it as part of this PR
since it was touching related code. For instance, I also had to add rebalance
jobType to the /table/tableName/{jobs} api, to retrieve all rebalance jobs.
Given the small change specifically for reload, my request is to include this
as part of this PR unless you strongly feel otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
