zhtaoxiang commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1132989635
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2151,16 +2166,42 @@ public boolean addNewReloadAllSegmentsJob(String
tableNameWithType, String jobId
Map<String, String> jobMetadata = new HashMap<>();
jobMetadata.put(CommonConstants.ControllerJob.JOB_ID, jobId);
jobMetadata.put(CommonConstants.ControllerJob.TABLE_NAME_WITH_TYPE,
tableNameWithType);
- jobMetadata.put(CommonConstants.ControllerJob.JOB_TYPE,
ControllerJobType.RELOAD_ALL_SEGMENTS.toString());
+ jobMetadata.put(CommonConstants.ControllerJob.JOB_TYPE,
ControllerJobType.RELOAD_SEGMENT.toString());
jobMetadata.put(CommonConstants.ControllerJob.SUBMISSION_TIME_MS,
Long.toString(System.currentTimeMillis()));
jobMetadata.put(CommonConstants.ControllerJob.MESSAGE_COUNT,
Integer.toString(numberOfMessagesSent));
- return addControllerJobToZK(jobId, jobMetadata);
- }
-
- private boolean addControllerJobToZK(String jobId, Map<String, String>
jobMetadata) {
- String jobResourcePath =
ZKMetadataProvider.constructPropertyStorePathForControllerJob();
+ return addControllerJobToZK(jobId, jobMetadata,
+
ZKMetadataProvider.constructPropertyStorePathForControllerJobResource(
+ ControllerJobType.RELOAD_SEGMENT.name()),
+ _propertyStore);
+ }
+ public static boolean addRebalanceResultToZk(String tableNameWithType,
Review Comment:
Do we need to retry if writing to zk fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
