swaminathanmanish commented on code in PR #10359: URL: https://github.com/apache/pinot/pull/10359#discussion_r1136457360
########## pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java: ########## @@ -112,14 +112,14 @@ public static String constructPropertyStorePathForInstancePartitions(String inst return StringUtil.join("/", PROPERTYSTORE_INSTANCE_PARTITIONS_PREFIX, instancePartitionsName); } - public static String constructPropertyStorePathForControllerJob() { Review Comment: @Jackie-Jiang and I discussed. Given this will be a backwards incompatible change, we will do this as a separate PR so that its easy to track which PR made that change. I'll keep reload_all and ZK_location the same for reload, force_commit, reload_all. cc @saurabhd336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org