saurabhd336 commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1133525613
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2070,13 +2073,14 @@ private Set<String> getAllInstancesForTable(String
tableNameWithType) {
}
/**
- * Returns the ZK metdata for the given jobId
+ * Returns the ZK metdata for the given jobId and resourceName
* @param jobId the id of the job
+ * @param resourceName Job Path
* @return Map representing the job's ZK properties
*/
- @Nullable
- public Map<String, String> getControllerJobZKMetadata(String jobId) {
- String controllerJobResourcePath =
ZKMetadataProvider.constructPropertyStorePathForControllerJob();
+ public Map<String, String> getControllerJobZKMetadataResource(String jobId,
String resourceName) {
Review Comment:
nit: @Nullable function annotation is still valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
