swaminathanmanish commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1138098201
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3124,13 +3176,30 @@ private PinotResourceManagerResponse
enableInstance(String instanceName, boolean
"Instance: " + instanceName + (enableInstance ? " enable" : "
disable") + " failed, timeout");
}
- public RebalanceResult rebalanceTable(String tableNameWithType,
Configuration rebalanceConfig)
+ /**
+ * Entry point for table Rebalacing.
+ * @param tableNameWithType
+ * @param rebalanceConfig
+ * @param helixZkManager
+ * @return RebalanceResult
+ * @throws TableNotFoundException
+ */
+ public static RebalanceResult rebalanceTable(String tableNameWithType,
Configuration rebalanceConfig,
Review Comment:
I wanted to unify all rebalance triggers in one place
(PinotHelixResourceManager.rebalanceTable) to leverage code, however after our
discussion, I've reverted this change. We decided that we want to track
rebalance only for the controller (UI triggered/manual rebalance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
