swaminathanmanish commented on code in PR #10359:
URL: https://github.com/apache/pinot/pull/10359#discussion_r1131616096
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -622,7 +622,8 @@ public SuccessResponse reloadSegmentDeprecated2(
public ServerReloadControllerJobStatusResponse getReloadJobStatus(
@ApiParam(value = "Reload job id", required = true) @PathParam("jobId")
String reloadJobId)
throws Exception {
- Map<String, String> controllerJobZKMetadata =
_pinotHelixResourceManager.getControllerJobZKMetadata(reloadJobId);
+ Map<String, String> controllerJobZKMetadata = _pinotHelixResourceManager.
+ getControllerJobZKMetadataResource(reloadJobId,
ControllerJobType.RELOAD_SEGMENT.name());
Review Comment:
I've used RELOAD_SEGMENT as the jobType for both the cases (reload,
reload_all). However I've retained RELOAD_ALL_SEGMENTS as a valid jobType for
now as the UI (reload status) depends on that parameter. Once UI is updated, I
can remove RELOAD_ALL_SEGMENTS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
