siddharthteotia commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1038888323
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ########## @@ -72,34 +75,34 @@ * 1. Change compression on raw SV and MV columns. * 2. Enabling dictionary on a raw column. * 3. Disable forward index on a column where it is enabled. + * 4. Enable forward index on a forward index disabled column Review Comment: Suggest changing to `"Rebuild forward index for noForwardIndex column"`. Sometimes the enable/disable term with `noForwardIndex` gets confusing because of the nature of the feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
