siddharthteotia commented on code in PR #9810:
URL: https://github.com/apache/pinot/pull/9810#discussion_r1038888131
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -72,34 +75,34 @@
* 1. Change compression on raw SV and MV columns.
* 2. Enabling dictionary on a raw column.
* 3. Disable forward index on a column where it is enabled.
+ * 4. Enable forward index on a forward index disabled column
*
* TODO: Add support for the following:
* 1. Disable dictionary
* 2. Segment versions < V3
- * 3. Enable forward index on a forward index disabled column
*/
-public class ForwardIndexHandler implements IndexHandler {
+public class ForwardIndexHandler extends BaseForwardIndexBasedIndexHandler {
private static final Logger LOGGER =
LoggerFactory.getLogger(ForwardIndexHandler.class);
- private final SegmentMetadata _segmentMetadata;
- private final IndexLoadingConfig _indexLoadingConfig;
+ // This should contain a list of all indexes that need to be rewritten if
the dictionary is enabled or disabled
+ private static final List<ColumnIndexType>
DICTIONARY_RELATED_INDEX_TO_REMOVE =
Review Comment:
Should this be called as `DICTIONARY_BASED_INDEX_TO_REWRITE` instead ?
If this is both `REMOVE` and `REWRITE`, then I think inverted index should
also be added to the list.
Based on Vivek's recent work, inv index is deleted after disabling
dictionary at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
