somandal commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1039989489
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseForwardIndexBasedIndexHandler.java: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.loader; + +import java.io.IOException; +import java.util.HashSet; +import java.util.Set; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.SegmentMetadata; +import org.apache.pinot.segment.spi.creator.IndexCreatorProvider; +import org.apache.pinot.segment.spi.store.ColumnIndexType; +import org.apache.pinot.segment.spi.store.SegmentDirectory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Base class for all of the {@link IndexHandler} classes which need to build their indexes from the forward index. + * This class handles temporarily rebuilding the forward index if the forward index does not exist and cleaning up + * the forward index once all handlers have completed via overriding the postUpdateIndicesCleanup() method. + */ +public abstract class BaseForwardIndexBasedIndexHandler implements IndexHandler { + private static final Logger LOGGER = LoggerFactory.getLogger(BaseForwardIndexBasedIndexHandler.class); + + protected final SegmentMetadata _segmentMetadata; + protected final IndexLoadingConfig _indexLoadingConfig; + protected final Set<String> _forwardIndexDisabledColumnsToCleanup; Review Comment: done ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ########## @@ -136,11 +139,28 @@ public void updateIndices(SegmentDirectory.Writer segmentWriter, IndexCreatorPro // forward index here which is dictionary based and allow the post deletion step handle the actual deletion // of the forward index. createDictBasedForwardIndex(column, segmentWriter, indexCreatorProvider); - Preconditions.checkState(segmentWriter.hasIndexFor(column, ColumnIndexType.FORWARD_INDEX), - String.format("Temporary forward index was not created for column: %s", column)); + if (!segmentWriter.hasIndexFor(column, ColumnIndexType.FORWARD_INDEX)) { + throw new IOException(String.format("Temporary forward index was not created for column: %s", column)); + } _forwardIndexDisabledColumnsToCleanup.add(column); break; } + case ENABLE_FORWARD_INDEX_FOR_DICT_COLUMN: { + createForwardIndexIfNeeded(segmentWriter, _segmentMetadata.getColumnMetadataFor(column), indexCreatorProvider, + false); + if (!segmentWriter.hasIndexFor(column, ColumnIndexType.DICTIONARY)) { + throw new IOException(String.format("Dictionary is not present for dictionary based column: %s", column)); + } + break; + } + case ENABLE_FORWARD_INDEX_FOR_RAW_COLUMN: { + createForwardIndexIfNeeded(segmentWriter, _segmentMetadata.getColumnMetadataFor(column), indexCreatorProvider, + false); + if (segmentWriter.hasIndexFor(column, ColumnIndexType.DICTIONARY)) { + throw new IOException(String.format("Dictionary is still present for noDictionary column: %s", column)); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
