somandal commented on code in PR #9810: URL: https://github.com/apache/pinot/pull/9810#discussion_r1039943060
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseForwardIndexBasedIndexHandler.java: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.loader; + +import java.io.IOException; +import java.util.HashSet; +import java.util.Set; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.SegmentMetadata; +import org.apache.pinot.segment.spi.creator.IndexCreatorProvider; +import org.apache.pinot.segment.spi.store.ColumnIndexType; +import org.apache.pinot.segment.spi.store.SegmentDirectory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Base class for all of the {@link IndexHandler} classes which need to build their indexes from the forward index. + * This class handles temporarily rebuilding the forward index if the forward index does not exist and cleaning up + * the forward index once all handlers have completed via overriding the postUpdateIndicesCleanup() method. + */ +public abstract class BaseForwardIndexBasedIndexHandler implements IndexHandler { Review Comment: Left a comment on the previous comment. Agree that this inheritance hierarchy isn't actually needed but I preferred doing it this way to ensure that we don't duplicate too much code around creating temporary forward index and cleaning it up for all `IndexHandlers` that need the forward index to create their respective indexes. Otherwise all the logic in this class will have to be duplicated across most `IndexHandler` classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
