siddharthteotia commented on code in PR #9810:
URL: https://github.com/apache/pinot/pull/9810#discussion_r1038885167
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -660,12 +677,12 @@ private void writeDictEnabledForwardIndex(String column,
ColumnMetadata existing
}
}
- private void removeDictRelatedIndexes(String column, SegmentDirectory.Writer
segmentWriter) {
+ static void removeDictRelatedIndexes(String column, SegmentDirectory.Writer
segmentWriter) {
// TODO: Move this logic as a static function in each index creator.
- segmentWriter.removeIndex(column, ColumnIndexType.RANGE_INDEX);
+ DICTIONARY_RELATED_INDEX_TO_REMOVE.forEach((index) ->
segmentWriter.removeIndex(column, index));
}
- private void updateMetadataProperties(File indexDir, Map<String, String>
metadataProperties)
+ static void updateMetadataProperties(File indexDir, Map<String, String>
metadataProperties)
Review Comment:
Hmm wondering if this will actually work in stateless / static fashion.
Caller need not do anything after `properties.save()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
