somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r966203964
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java:
##########
@@ -142,6 +145,8 @@ public PhysicalColumnIndexContainer(SegmentDirectory.Reader
segmentReader, Colum
// Single-value
if (metadata.isSorted()) {
// Sorted
+ // forwardIndexDisabled columns do not need to be handled here as
forward index cannot be disabled on a
Review Comment:
yes it is okay for 157 to be called with `fwdIndexBuffer` as null. We only
set this to null if the forward index is disabled. When the forward index
reader is created, the No-op forward index reader will be assigned which
doesn't need a `fwdIndexBuffer`. I've added a comment where I set
`fwdIndexBuffer` to indicate this behavior is expected. Let me know if you
would like more clarification on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
