siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r965621946
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -869,6 +871,25 @@ private static void validateFieldConfigList(@Nullable
List<FieldConfig> fieldCon
default:
break;
}
+
+ // Validate the forward index disabled compatibility if enabled for
this column
+ Map<String, String> fieldConfigProperties =
fieldConfig.getProperties();
+ if (fieldConfigProperties != null) {
+ boolean forwardIndexDisabled =
Boolean.parseBoolean(fieldConfigProperties
+ .getOrDefault(FieldConfig.FORWARD_INDEX_DISABLED,
FieldConfig.DEFAULT_FORWARD_INDEX_DISABLED));
+ if (forwardIndexDisabled) {
+ Preconditions.checkState((noDictionaryColumns == null ||
!noDictionaryColumns.contains(columnName))
Review Comment:
suggest splitting the check into multiple checks for clearer message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
