siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r965603378
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/DefaultIndexCreatorProvider.java:
##########
@@ -88,17 +90,25 @@ public ForwardIndexCreator
newForwardIndexCreator(IndexCreationContext.Forward c
context.getMaxRowLengthInBytes());
}
} else {
- if (context.getFieldSpec().isSingleValueField()) {
- if (context.isSorted()) {
- return new
SingleValueSortedForwardIndexCreator(context.getIndexDir(),
context.getFieldSpec().getName(),
- context.getCardinality());
+ if (context.forwardIndexDisabled()) {
Review Comment:
(nit) not related to this PR -- do you mind adding a comment under the else
branch above line 93 ? something like `Dictionary enabled column`. Will make it
bit more readable. Similarly above line 79 `NoDictionary column`
We may also want to make this more readable by having separate helper method
but separate PR for that is fine too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
