Jackie-Jiang commented on code in PR #8989: URL: https://github.com/apache/pinot/pull/8989#discussion_r939460495
########## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java: ########## @@ -127,6 +127,13 @@ public ZNRecord toZNRecord() { return znRecord; } + /** + * Returns a new instance of InstancePartitions with the given name + */ + public InstancePartitions withName(String newName) { Review Comment: Sounds good since it is not in performance critical path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org