ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r920232211
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1688,13 +1690,22 @@ private void assignInstances(TableConfig tableConfig,
boolean override) {
}
}
+ boolean isTableInGroup = TableConfigUtils.isTableInGroup(tableConfig);
Review Comment:
> Creating a new TableGroup out of N existing tables
Yes current approach is based on option-1.
> Adding an existing table to an existing TableGroup
>
> This is like steps 2,3,4 of option 1 mentioned above. Correct ?
Yes that's correct.
I'll update the code and doc with more details on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
