ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r920228795
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1688,13 +1690,22 @@ private void assignInstances(TableConfig tableConfig,
boolean override) {
}
}
+ boolean isTableInGroup = TableConfigUtils.isTableInGroup(tableConfig);
Review Comment:
> **Adding a new table to TableGroup that pre-exists with 1 or more tables.**
Yes this is supported. To do this one can edit the table-config for the
corresponding table and set the `groupName` field. You will have to initiate a
rebalance on the table to ensure data is moved around appropriately for that
table.
> The other way to do is that when TableGroup is created, it triggers
InstanceAssignment by calling the driver.
Yup this is how I am doing it right now. You can refer to the
createTableGroup API in PinotTableGroupRestletResource. When the table-group is
created, we perform instance assignment for the same and persist it in ZK for
future re-use.
When we need to update the instance assignment for the group (due to
addition/removal of instances), we can initiate a "Re-compute Table Group"
operation from the UI and will then have to call Rebalance for each of the
tables. The "Re-compute" operation will do the instance assignment for the
group again and update the same in ZK. When we initiate rebalance for a table
in the group, data will move around for that table based on the newly updated
instance partitions for the group.
Later, I am also planning to add a "Re-balance Table Group" option in the UI
which should move the data for all the tables in the group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
