ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r928346232


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -881,6 +884,18 @@ private static void validateFieldConfigList(@Nullable 
List<FieldConfig> fieldCon
     }
   }
 
+  private static void validateTableGroupConfig(TableConfig tableConfig) {
+    if (StringUtils.isBlank(tableConfig.getTableGroupName())) {
+      return;
+    }
+    
Preconditions.checkState(tableConfig.getValidationConfig().getReplicaGroupStrategyConfig()
 != null, "Must provide"

Review Comment:
   Thanks, I was also confused about `replicaGroupStrategyConfig`. I have 
removed it from the validation logic now and instead check for column partition 
map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to