Jackie-Jiang commented on code in PR #8989: URL: https://github.com/apache/pinot/pull/8989#discussion_r922712731
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java: ########## @@ -101,6 +102,9 @@ public class TableConfig extends BaseJsonConfig { @JsonPropertyDescription(value = "Configs for Table config tuner") private List<TunerConfig> _tunerConfigList; + @JsonPropertyDescription(value = "Name of the table-group") + private String _tableGroupName; Review Comment: One table group can refer to one `InstanceAssignment`, but one table might be associated with multiple `InstanceAssignment`. Should we keep a map from `InstancePartitionsType` to group name, or consider adding group name as a field of `InstanceAssignmentConfig`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org