[GitHub] [pinot] deemoliu commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

[GitBox]

deemoliu commented on code in PR #9062:
URL: https://github.com/apache/pinot/pull/9062#discussion_r929421458


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -213,6 +214,13 @@ public List<StarTreeV2> getStarTrees() {
     return _starTreeIndexContainer != null ? 
_starTreeIndexContainer.getStarTrees() : null;
   }
 
+  @Nullable
+  public void setValidDocIds(ImmutableRoaringBitmap validDocIds) {
+    for (int docId: validDocIds.toArray()) {
+      _validDocIds.add(docId);

Review Comment:
   Thanks @yupeng9 
   
   Previously i tried to set the validDocIndex directly from snapshot. so i 
iterate validDocId from immutableRoaringBitmap to ThreadSafeRoaringBitmap. I 
synced with Jackie and learned this is not correct, so I fix it in `[this 
commit](https://github.com/apache/pinot/pull/9062/commits/56fb2a6b629473f5a64eb945597092854a39c3ba)`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org