Jackie-Jiang commented on code in PR #9062:
URL: https://github.com/apache/pinot/pull/9062#discussion_r935906982


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -55,12 +55,16 @@ public enum Strategy {
   @JsonPropertyDescription("Column for upsert comparison, default to time 
column")
   private final String _comparisonColumn;
 
+  @JsonPropertyDescription("whether use snapshot for fast upsert metadata 
recovery")
+  private boolean _useSnapshot;
+
   @JsonCreator
   public UpsertConfig(@JsonProperty(value = "mode", required = true) Mode mode,

Review Comment:
   We may deprecate the current constructor and add an empty constructor to 
keep backward compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to