deemoliu commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r935859820
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ########## @@ -213,6 +215,16 @@ public List<StarTreeV2> getStarTrees() { return _starTreeIndexContainer != null ? _starTreeIndexContainer.getStarTrees() : null; } + @Nullable + public void setValidDocSnapshots(ImmutableRoaringBitmap validDocSnapshots) { Review Comment: gotcha, thanks for pointing out, let me address this. ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ########## @@ -213,6 +215,16 @@ public List<StarTreeV2> getStarTrees() { return _starTreeIndexContainer != null ? _starTreeIndexContainer.getStarTrees() : null; } + @Nullable + public void setValidDocSnapshots(ImmutableRoaringBitmap validDocSnapshots) { + _validDocSnapshots = validDocSnapshots; + } + + @Nullable + public ImmutableRoaringBitmap getValidDocSnapshots() { Review Comment: gotcha, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org