deemoliu commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r928003568
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java: ########## @@ -198,6 +201,13 @@ public void init(SegmentGeneratorConfig config, SegmentCreationDataSource dataSo // Create a temporary directory used in segment creation _tempIndexDir = new File(indexDir, "tmp-" + UUID.randomUUID()); LOGGER.debug("tempIndexDir:{}", _tempIndexDir); + + _upsertSnapshotEnabled = _config.isUpsertSnapshotEnabled(); Review Comment: Thanks @Jackie-Jiang i planned to create another PR for TTL-related config and logics. Do you think I should add that in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org