deemoliu commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r929419135
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ########## @@ -142,7 +142,7 @@ public class OfflineClusterIntegrationTest extends BaseClusterIntegrationTestSet private static final String MAX_NUM_MULTI_VALUES_MAP_KEY = "maxNumMultiValuesMap"; // TODO: This might lead to flaky test, as this disk size is not deterministic // as it depends on the iteration order of a HashSet. - private static final int DISK_SIZE_IN_BYTES = 20796000; + private static final int DISK_SIZE_IN_BYTES = 20796348; Review Comment: thanks @yupeng9 for review. I added "segment.use.ttl" properties in the metadata. When load from disk, I use this properties from `segmentMetadataPropertiesConfiguration` to initialize [validDocSnapshot](https://github.com/apache/pinot/pull/9062/commits/6bfab718afadfaa7139de227dd27edf7d0a44b9e) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
