nizarhejazi commented on code in PR #8503: URL: https://github.com/apache/pinot/pull/8503#discussion_r860289907
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java: ########## @@ -411,9 +419,10 @@ private static void unnestResults(List<Map<String, String>> currentResults, public static Schema getPinotSchemaFromJsonFile(File jsonFile, Review Comment: As mentioned in the other comment, enabling parsing of exact BigDecimal may end up causing floats/doubles to be parsed as BigDecimal too and we need to cast to the proper data type so that code that compare parsed vs. actual does not fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
