nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r859373137
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java:
##########
@@ -226,6 +246,27 @@ public double[] transformToDoubleValuesSV(ProjectionBlock
projectionBlock) {
return _doubleValuesSV;
}
+ @Override
+ public BigDecimal[] transformToBigDecimalValuesSV(ProjectionBlock
projectionBlock) {
+ int length = projectionBlock.getNumDocs();
+ if (_bigDecimalValuesSV == null || _bigDecimalValuesSV.length < length) {
+ _bigDecimalValuesSV = new BigDecimal[length];
+ }
+
+ Dictionary dictionary = getDictionary();
+ if (dictionary != null) {
+ int[] dictIds = transformToDictIdsSV(projectionBlock);
+ dictionary.readBigDecimalValues(dictIds, length, _bigDecimalValuesSV);
+ } else {
+ if (getResultMetadata().getDataType().getStoredType() ==
DataType.STRING) {
Review Comment:
yes, I think so. I had it in my original PR. Will add back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
