nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r860289907
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##########
@@ -411,9 +419,10 @@ private static void unnestResults(List<Map<String,
String>> currentResults,
public static Schema getPinotSchemaFromJsonFile(File jsonFile,
Review Comment:
Enabling parsing of exact BigDecimal may end up causing floats/doubles to be
parsed as BigDecimal.
Please note that we may need to convert BigDecimal back to double/float.
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/JsonToPinotSchema.java:
##########
@@ -78,6 +78,10 @@ public class JsonToPinotSchema extends
AbstractBaseAdminCommand implements Comma
+ "JSON string, can be NONE/NON_PRIMITIVE/ALL")
String _collectionNotUnnestedToJson;
+ @CommandLine.Option(names = {"-parseExactBigDecimal"}, description =
"Whether to parse exact BigDecimal or parse "
+ + "BigDecimal as doubles, default to false")
+ Boolean _parseExactBigDecimal = false;
Review Comment:
The problem here is that attempting to parse BigDecimal as is may result in
doubles (in some occasions) being parsed as BigDecimal and sometimes float
being parsed as BigDecimal which is a backward incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
