nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r851733056
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java:
##########
@@ -45,30 +46,32 @@ public class LiteralTransformFunction implements
TransformFunction {
private final long _longLiteral;
private final float _floatLiteral;
private final double _doubleLiteral;
+ private final BigDecimal _bigDecimalLiteral;
// literals may be shared but values are intentionally not volatile as
assignment races are benign
private int[] _intResult;
private long[] _longResult;
private float[] _floatResult;
private double[] _doubleResult;
+ private BigDecimal[] _bigDecimalResult;
private String[] _stringResult;
private byte[][] _bytesResult;
public LiteralTransformFunction(String literal) {
_literal = literal;
_dataType = inferLiteralDataType(literal);
- if (_dataType.isNumeric()) {
- BigDecimal bigDecimal = new BigDecimal(_literal);
- _intLiteral = bigDecimal.intValue();
- _longLiteral = bigDecimal.longValue();
- _floatLiteral = bigDecimal.floatValue();
- _doubleLiteral = bigDecimal.doubleValue();
+ if (_dataType == DataType.TIMESTAMP) {
+ _bigDecimalLiteral =
BigDecimal.valueOf(Timestamp.valueOf(literal).getTime());
Review Comment:
inferLiteralDataType() can return DataType.TIMESTAMP. Once
_bigDecimalLiteral is set, other literal values including _longLiteral is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
