nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r851733275
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java:
##########
@@ -362,6 +364,12 @@ private void getNonLiteralValues(ProjectionBlock
projectionBlock) {
case DOUBLE:
_nonLiteralValues[i] =
ArrayUtils.toObject(transformFunction.transformToDoubleValuesSV(projectionBlock));
break;
+ case BIG_DECIMAL:
+ byte[][] byteValues =
transformFunction.transformToBytesValuesSV(projectionBlock);
+ BigDecimal[] bigDecimalValues = new BigDecimal[byteValues.length];
+ ArrayCopyUtils.copy(byteValues, bigDecimalValues, byteValues.length);
Review Comment:
I think this comment is outdated.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java:
##########
@@ -225,6 +230,11 @@ public byte[][] transformToBytesValuesSV(ProjectionBlock
projectionBlock) {
if (bytesResult == null || bytesResult.length < numDocs) {
bytesResult = new byte[numDocs][];
Arrays.fill(bytesResult, BytesUtils.toBytes(_literal));
Review Comment:
I think this comment is outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
