Jackie-Jiang commented on PR #8564: URL: https://github.com/apache/pinot/pull/8564#issuecomment-1103238294
I don't follow the fix here. Let's say a consuming segment is dropped (or reset), we will destroy the current consuming segment, and that will add a checkpoint to the source. The next consuming segment will skip the records within the dropped segment, and cause data loss. IMO we should add the checkpoint only when then previous segment is successfully sealed and we want to start a new consuming segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
