[GitHub] [pinot] mcvsubbu commented on a diff in pull request #8564: Invoke checkpoint before closing partition group consumer

[GitBox]

mcvsubbu commented on code in PR #8564:
URL: https://github.com/apache/pinot/pull/8564#discussion_r852331586


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -978,6 +978,7 @@ private void closeStreamConsumers() {
 
   private void closePartitionGroupConsumer() {
     try {
+      _currentOffset = _partitionGroupConsumer.checkpoint(_currentOffset);

Review Comment:
   Why not modify the interface to have a `close(offset)` call ? that way, 
underlying streams can do whatever they want with the offset.
   
   Also, it mirrors how the consumer is constructed with the start offset



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org