navina commented on code in PR #8564:
URL: https://github.com/apache/pinot/pull/8564#discussion_r852338846
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -978,6 +978,7 @@ private void closeStreamConsumers() {
private void closePartitionGroupConsumer() {
try {
+ _currentOffset = _partitionGroupConsumer.checkpoint(_currentOffset);
Review Comment:
1. I would like to avoid interface changes for bugfixes. This is a bug that
is valid only after the introduction of checkpoint interface.
2. It is not just the underlying streams that need to handle this. The
LLRealtimeSegmentDataManager should also use the current offset when creating a
new consumer and not always the startOffset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
