navina commented on PR #8564: URL: https://github.com/apache/pinot/pull/8564#issuecomment-1102096897
> lgtm! Is there ay scope to add a unit test to check that the partitionGroupConsumer starts with the right startOffset across closes? I took a quick look. It is using a lot of mock/fake classes and based on my understanding, it is not possible to test this behavior easily. :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org