Jackie-Jiang commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r467503689
########## File path: pinot-common/src/main/java/org/apache/pinot/common/tier/PinotServerTierStorage.java ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.tier; + +import org.apache.pinot.common.tier.TierFactory.TierStorageType; + + +/** + * Tier storage type which uses Pinot servers as storage + */ +public class PinotServerTierStorage implements TierStorage { + private final String _type = TierStorageType.PINOT_SERVER.toString(); + private final String _tag; + + public PinotServerTierStorage(String tag) { + _tag = tag; + } + + /** + * Returns the tag used to identify the servers being used as the tier storage + */ + public String getTag() { + return _tag; + } + + @Override + public String getType() { Review comment: Should we return `TierStorageType` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
