npawar commented on a change in pull request #5793:
URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r467323322
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java
##########
@@ -40,41 +41,51 @@
/**
- * Periodic task to run rebalancer in background to relocate COMPLETED
segments for LLC real-time table. Allow at most
- * one replica unavailable during rebalance.
+ * Periodic task to run rebalancer in background to
+ * 1. relocate COMPLETED segments to tag overrides
+ * 2. relocate ONLINE segments to tiers if tier configs are set
+ * Allow at most one replica unavailable during rebalance. Not applicable for
HLC tables.
*/
-public class RealtimeSegmentRelocator extends ControllerPeriodicTask<Void> {
- private static final Logger LOGGER =
LoggerFactory.getLogger(RealtimeSegmentRelocator.class);
+public class SegmentRelocator extends ControllerPeriodicTask<Void> {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(SegmentRelocator.class);
private final ExecutorService _executorService;
- public RealtimeSegmentRelocator(PinotHelixResourceManager
pinotHelixResourceManager,
+ public SegmentRelocator(PinotHelixResourceManager pinotHelixResourceManager,
LeadControllerManager leadControllerManager, ControllerConf config,
ControllerMetrics controllerMetrics,
ExecutorService executorService) {
- super("RealtimeSegmentRelocator",
getRunFrequencySeconds(config.getRealtimeSegmentRelocatorFrequency()),
- config.getRealtimeSegmentRelocationInitialDelayInSeconds(),
pinotHelixResourceManager, leadControllerManager,
+ super(SegmentRelocator.class.getSimpleName(), 60,
+ 30, pinotHelixResourceManager, leadControllerManager,
Review comment:
removed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
